Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing non-sendable cmsg in SendMsg syscall should fail #7188

Open
arthurpi opened this issue Feb 15, 2022 · 2 comments
Open

Parsing non-sendable cmsg in SendMsg syscall should fail #7188

arthurpi opened this issue Feb 15, 2022 · 2 comments
Labels
area: networking Issue related to networking no-auto-close type: bug Something isn't working

Comments

@arthurpi
Copy link
Contributor

Description

Some control messages can't be sent (only received). For example, IP_RECVERR or IP_RECVORIGDSTADDR.

In the syscall implementation of SendMsg in sentry, we call control.Parse on the raw cmsg bytes. This function should refuse non-sendable control messages.

Steps to reproduce

No response

runsc version

No response

docker version (if using docker)

No response

uname

No response

kubectl (if using Kubernetes)

No response

repo state (if built from source)

No response

runsc debug logs (if available)

No response
@arthurpi arthurpi added type: bug Something isn't working area: networking Issue related to networking labels Feb 15, 2022
@sourikghosh
Copy link

Hey, @arthurpi can I pick this issue. And can you give me some hints on where to start looking for making this change?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 120 days.

@github-actions github-actions bot added the stale-issue This issue has not been updated in 120 days. label Sep 13, 2023
@avagin avagin added no-auto-close and removed stale-issue This issue has not been updated in 120 days. labels Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: networking Issue related to networking no-auto-close type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avagin @arthurpi @sourikghosh