Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop RouteInfo and NetworkProtocolNumber from LinkEndpoint.WritePacket{s} #6537

Closed
ghananigans opened this issue Sep 1, 2021 · 0 comments · Fixed by #6994
Closed

Drop RouteInfo and NetworkProtocolNumber from LinkEndpoint.WritePacket{s} #6537

ghananigans opened this issue Sep 1, 2021 · 0 comments · Fixed by #6994
Assignees
@ghananigans
Labels
area: networking Issue related to networking type: bug Something isn't working

Comments

@ghananigans
Copy link
Member

ghananigans commented Sep 1, 2021 •
edited

These fields are held in the packet buffer.
@ghananigans ghananigans added the type: bug Something isn't working label Sep 1, 2021
@ghananigans ghananigans self-assigned this Sep 1, 2021
@ghananigans ghananigans added the area: networking Issue related to networking label Sep 1, 2021
@ghananigans ghananigans changed the title Drop tcpip.NetworkProtocolNumber from LinkEndpoint.WritePacket{s} Drop RouteInfo and NetworkProtocolNumber from LinkEndpoint.WritePacket{s} Sep 1, 2021
@copybara-service copybara-service bot mentioned this issue Dec 20, 2021
Merged
copybara-service bot pushed a commit that referenced this issue Dec 21, 2021
@tamird @gvisor-bot
Delete channel.PacketInfo
b91cc35 
Updates #6537.

PiperOrigin-RevId: 417507096
copybara-service bot pushed a commit that referenced this issue Dec 28, 2021
@ghananigans @gvisor-bot
Don't pass route info and net proto to write fns
62147bb 
...as the packet buffer already holds that information.

Updates #3810.
Fixes #6537.

PiperOrigin-RevId: 418682175
@copybara-service copybara-service bot mentioned this issue Dec 28, 2021
Merged
@ghananigans ghananigans mentioned this issue Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghananigans ghananigans

Labels
area: networking Issue related to networking type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't pass route info and net proto to write fns google/gvisor
1 participant
@ghananigans